From e1dd92a4f9c249812b70ef2469442954567d7e5c Mon Sep 17 00:00:00 2001 From: Dave Cross Date: Fri, 13 Jan 2023 10:40:00 +0000 Subject: [PATCH 1/2] Add failing test --- t/file.spec | 1 + t/parse-rpm-spec.t | 1 + 2 files changed, 2 insertions(+) diff --git a/t/file.spec b/t/file.spec index 844028f..b92537e 100644 --- a/t/file.spec +++ b/t/file.spec @@ -13,6 +13,7 @@ BuildRequires: perl >= 1:5.6.0 BuildRequires: perl(Module::Build) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) ExclusiveArch: megaCPU +ExcludeArch: crapOS %description If you have two arrays and you want to know if they are the same or diff --git a/t/parse-rpm-spec.t b/t/parse-rpm-spec.t index 84376c4..33321ac 100644 --- a/t/parse-rpm-spec.t +++ b/t/parse-rpm-spec.t @@ -23,6 +23,7 @@ is($spec->buildrequires->[0], 'perl >= 1:5.6.0', 'First build requirement is correct'); is($spec->exclusivearch, 'megaCPU', 'Correct exclusive architecture'); +is($spec->excludearch, 'crapCPU', 'Correct excluded architecture'); dies_ok { Parse::RPM::Spec->new } 'No spec file given'; From e229a81b61c7af579cc704fe97cbcde5b42248cd Mon Sep 17 00:00:00 2001 From: Dave Cross Date: Fri, 13 Jan 2023 10:41:18 +0000 Subject: [PATCH 2/2] Make test pass --- lib/Parse/RPM/Spec.pm | 2 +- t/file.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Parse/RPM/Spec.pm b/lib/Parse/RPM/Spec.pm index 2e8a6f6..45dc02b 100644 --- a/lib/Parse/RPM/Spec.pm +++ b/lib/Parse/RPM/Spec.pm @@ -23,7 +23,7 @@ has buildroot => ( is => 'rw', isa => 'Str' ); has buildarch => ( is => 'rw', isa => 'Str' ); has buildrequires => ( is => 'rw', isa => 'ArrayRef[Str]', default => sub { [] } ); has requires => ( is => 'rw', isa => 'ArrayRef[Str]', default => sub { [] } ); -has [ qw( excluderach exclusivearch excludeos exclusiveos ) ] +has [ qw( excludearch exclusivearch excludeos exclusiveos ) ] => ( is => 'rw', isa => 'Str' ); has parse_spec => ( diff --git a/t/file.spec b/t/file.spec index b92537e..413f402 100644 --- a/t/file.spec +++ b/t/file.spec @@ -13,7 +13,7 @@ BuildRequires: perl >= 1:5.6.0 BuildRequires: perl(Module::Build) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) ExclusiveArch: megaCPU -ExcludeArch: crapOS +ExcludeArch: crapCPU %description If you have two arrays and you want to know if they are the same or