From 780b0b886ff041c48e2463b02cdb2500202c73bd Mon Sep 17 00:00:00 2001
From: Dave Cross <dave@dave.org.uk>
Date: Sat, 23 Jan 2021 12:12:20 +0000
Subject: [PATCH] Act on some Kritika feedback

---
 lib/Parse/RPM/Spec.pm | 2 +-
 t/parse-rpm-spec.t    | 5 ++++-
 t/pod.t               | 3 +++
 t/pod_coverage.t      | 3 +++
 4 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/lib/Parse/RPM/Spec.pm b/lib/Parse/RPM/Spec.pm
index 961219f..c1f2cbb 100644
--- a/lib/Parse/RPM/Spec.pm
+++ b/lib/Parse/RPM/Spec.pm
@@ -83,7 +83,7 @@ sub parse_file {
     croak "Spec file $file is empty\n";
   }
 
-  open my $fh, $file or croak "Cannot open $file: $!\n";
+  open my $fh, '<', $file or croak "Cannot open $file: $!\n";
 
   my $scalars = $self->parse_spec->{scalars};
   my $arrays  = $self->parse_spec->{arrays};
diff --git a/t/parse-rpm-spec.t b/t/parse-rpm-spec.t
index c776e09..b5f8fb8 100644
--- a/t/parse-rpm-spec.t
+++ b/t/parse-rpm-spec.t
@@ -1,9 +1,12 @@
+use strict;
+use warnings;
+
 use Test::More;
 use Test::Exception;
 
 BEGIN { use_ok('Parse::RPM::Spec') };
 
-ok($spec = Parse::RPM::Spec->new( { file => 't/file.spec' } ),
+ok(my $spec = Parse::RPM::Spec->new( { file => 't/file.spec' } ),
   'Got an object');
 isa_ok($spec, 'Parse::RPM::Spec');
 
diff --git a/t/pod.t b/t/pod.t
index 437887a..d6e05a9 100644
--- a/t/pod.t
+++ b/t/pod.t
@@ -1,3 +1,6 @@
+use strict;
+use warnings;
+
 use Test::More;
 eval "use Test::Pod 1.00";
 plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
diff --git a/t/pod_coverage.t b/t/pod_coverage.t
index d692068..a2cc35f 100644
--- a/t/pod_coverage.t
+++ b/t/pod_coverage.t
@@ -1,3 +1,6 @@
+use strict;
+use warnings;
+
 use Test::More;
 eval "use Test::Pod::Coverage 1.00";
 plan skip_all => "Test::Pod::Coverage 1.00 required for testing POD coverage" if $@;