zyppe/parse-rpm-spec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Act on some Kritika feedback

Browse source
This commit is contained in:
Dave Cross 2021-01-23 12:12:20 +00:00
parent 43d0bfc5d8
commit 780b0b886f
4 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/Parse/RPM/Spec.pm
View file

@ -83,7 +83,7 @@ sub parse_file {
croak "Spec file $file is empty\n"; croak "Spec file $file is empty\n";
} }
open my $fh, $file or croak "Cannot open $file: $!\n"; open my $fh, '<', $file or croak "Cannot open $file: $!\n";
my $scalars = $self->parse_spec->{scalars}; my $scalars = $self->parse_spec->{scalars};
my $arrays = $self->parse_spec->{arrays}; my $arrays = $self->parse_spec->{arrays};

5
t/parse-rpm-spec.t
View file

@ -1,9 +1,12 @@
use strict;
use warnings;
use Test::More; use Test::More;
use Test::Exception; use Test::Exception;
BEGIN { use_ok('Parse::RPM::Spec') }; BEGIN { use_ok('Parse::RPM::Spec') };
ok($spec = Parse::RPM::Spec->new( { file => 't/file.spec' } ), ok(my $spec = Parse::RPM::Spec->new( { file => 't/file.spec' } ),
'Got an object'); 'Got an object');
isa_ok($spec, 'Parse::RPM::Spec'); isa_ok($spec, 'Parse::RPM::Spec');

3
t/pod.t
View file

@ -1,3 +1,6 @@
use strict;
use warnings;
use Test::More; use Test::More;
eval "use Test::Pod 1.00"; eval "use Test::Pod 1.00";
plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;

3
t/pod_coverage.t
View file

@ -1,3 +1,6 @@
use strict;
use warnings;
use Test::More; use Test::More;
eval "use Test::Pod::Coverage 1.00"; eval "use Test::Pod::Coverage 1.00";
plan skip_all => "Test::Pod::Coverage 1.00 required for testing POD coverage" if $@; plan skip_all => "Test::Pod::Coverage 1.00 required for testing POD coverage" if $@;